Skip to content

Conversation

hansmohrmann
Copy link

This is probably not the best way to do this, but I figured I would start with the simplest way and go from there.

inline_array snakes its way through the codebase all the way to _maybe_chunk where it gets resolved against from_array_kwargs; if you provide it in from_array_kwargs and explicitly to open_dataset, you get @dcherian's error message. So with open_zarr you can't provide it in from_array_kwargs since the default open_dataset value is used (False); this PR just removes it from from_array_kwargs and passes that value to open_dataset.

Pros:

  • Doesn't require changing the signature of anything.

Cons:

  • open_zarr is now the one place where you can use inline_array in from_array_kwargs, which might lead to some confusion down the line.
  • Have tied the default value in open_dataset to open_zarr.

So alternatively, I could modify open_zarr with another inline_array arg.

Copy link

welcome bot commented May 29, 2025

Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient.
If you have questions, some answers may be found in our contributing guidelines.

@hansmohrmann
Copy link
Author

@TomNicholas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
io topic-backends topic-zarr Related to zarr storage library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support inline_array kwarg in open_zarr
2 participants